Fix members component and e2e tests #1397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowska
requested review from
ActiveChooN,
MarkRedeman,
camiloHimura,
dwesolow,
jpggvilaca and
pplaskie
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables a failing end-to-end test in the daily test suite by skipping the "Members management" test. The change includes a TODO comment indicating that a proper fix will be implemented in a separate PR.
- Adds
test.skip()to temporarily disable the failing Members management test - Includes a TODO comment explaining the temporary nature of the skip
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jpggvilaca
reviewed
Oct 16, 2025
romanowska
changed the title
ActiveChooN
approved these changes
Oct 22, 2025
| password: 'Test1234', | ||
| role: USER_ROLE.WORKSPACE_ADMIN, | ||
| workspaceRole: USER_ROLE.WORKSPACE_ADMIN, | ||
| organizationRole: USER_ROLE.ORGANIZATION_ADMIN, |
There was a problem hiding this comment.
The user should not have the ORGNIZATION_ADMIN role and any other role simultaneously.
| await membersPage.resetSearchFilter(); | ||
| }); | ||
|
|
||
| await test.step('Edits workspace admin and workspace contributor member', async () => { |
There was a problem hiding this comment.
Should this test and the next one be renamed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: